Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PermissionState is declare in ed/permissions and ed/orientation_event, are they the same? #467

Closed
jodinathan opened this issue Jan 28, 2022 · 7 comments
Closed

PermissionState is declare in ed/permissions and ed/orientation_event, are they the same? #467

jodinathan opened this issue Jan 28, 2022 · 7 comments

Comments

@jodinathan
Copy link

They are in both permissions and orientation_event, however, only in permissions it has the prompt value.

Should I merge them or use separately?
@jodinathan
Copy link
Author

Keyboard is also declared in keyboard_map and keyboard_lock, but they have different structures

@jodinathan
Copy link
Author

SVGElement is also declared in svg2 and svg11. Should I use the one from svg11?

@jodinathan
Copy link
Author

sorry flooding this and bothering you, I am just trying to make the crawler right =/
PerformanceMarkOptions is also declared in user_timing_3 and user_timing_2

@marcoscaceres
Copy link
Member

No, thanks for bringing this up! We need to fix the duplicates.

@marcoscaceres
Copy link
Member

About PermissionState: w3c/deviceorientation#88

For the others, we would need to check if bugs are filed on the appropriate specs.

@tidoust tidoust mentioned this issue Feb 1, 2022
Closed
@tidoust
Copy link
Member

tidoust commented Feb 1, 2022

The raw crawl data in the main branch may contain duplicates.

The curated version of the data in the curated branch comes with a "no duplicate top-level definitions or members" guarantee for idl in the idl folder. This is enforced by tests. Duplicates are removed during curation through patches, and patches are normally linked to issues or pull requests raised against the underlying specs.

There is a bug in Reffy for the idlparsed folder that makes it create more than one parsed version of the same IDL extract, creating artificial duplication of terms. See w3c/reffy#844

PerformanceMarkOptions is also declared in user_timing_3 and user_timing_2

User Timing has been versionless for a couple of months. There should only remain extracts named user-timing. I see there remain a couple of extracts under tr/ids, which is a mistake. That said, I don't understand where you see two occurrences of PerformanceMarkOptions?

tidoust added a commit that referenced this issue Feb 1, 2022
@tidoust
Make sure that clean job processes all folders
cff6739 
The list of folders to check was hardcoded, and `ids` was not in the list.

This update computes the list automatically looking at the `ed` folder
(assuming that the `tr` list is the same).

Via #467 (comment)
@tidoust tidoust mentioned this issue Feb 1, 2022
Merged
tidoust added a commit that referenced this issue Feb 1, 2022
@tidoust
Make sure that clean job processes all folders (#481)
a5b2c2a 
The list of folders to check was hardcoded, and `ids` was not in the list.

This update computes the list automatically looking at the `ed` folder
(assuming that the `tr` list is the same).

Via #467 (comment)
@jodinathan
Copy link
Author

everything seem working in the curated branch

really grateful for your work there, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcoscaceres @tidoust @jodinathan