Set cancelable flag for "cancel" event (dialog and CloseWatcher)
#1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent HTML update changed the creation conditions for the "cancel" event for `HTMLDialogElement` and `CloseWatcher`: https://github.com/whatwg/html/pull/10291/files The extraction code no longer detects the `cancelable` flag as a result. In any case, the code that amended the event to split `HTMLElement` into `HTMLInputElement` and `HTMLDialogElement` was incorrect: the `cancelable` flag ended up on `HTMLInputElement` whereas it should have been set on the other two target interfaces. One interesting aspect of the HTML update is that it seems to make the event cancelable depending on conditions. We cannot express that nuance with a boolean flag.
dontcallmedom
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent HTML update changed the creation conditions for the "cancel" event for
HTMLDialogElementandCloseWatcher:https://github.com/whatwg/html/pull/10291/files
The extraction code no longer detects the
cancelableflag as a result.In any case, the code that amended the event to split
HTMLElementintoHTMLInputElementandHTMLDialogElementwas incorrect: thecancelableflag ended up onHTMLInputElementwhereas it should have been set on the other two target interfaces. The amendment is now explicit on bothbubblesandcancelableto avoid any bad surprise.One interesting aspect of the HTML update is that it seems to make the event cancelable depending on conditions. We cannot express that nuance with a boolean flag... I propose to set the flag to
true.