Adjust workflows to release a @webref/elements package #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts workflows to also handle and release a `@webref/elements` package, as discussed in #51. Tests guarantee that interfaces that appear in the package also exist in the `@webref/idl`. Ideally, the IDL package should be added as peer dependency to the elements package but that creates a chicken-and-egg situation as we will likely often release packages together. Patches are an overkill for now but could prove useful in the long run. The update also splits CSS, elements, and IDL tests. That is a first step towards addressing #237. It does not fully solve it though, as IDL patches are still applied when the CSS package is released.
dontcallmedom
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts workflows to also handle and release a
@webref/elementspackage, as discussed in #51. Tests guarantee that interfaces that appear in the package also exist in the@webref/idl.Ideally, the IDL package should be added as peer dependency to the elements package but that creates a chicken-and-egg situation as we will likely often release packages together.
Patches are an overkill for now but could prove useful in the long run.
The update also splits CSS, elements, and IDL tests. That is a first step towards addressing #237. It does not fully solve it though, as IDL patches are still applied when the CSS package is released.