Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Lerna to independent mode #94

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 12, 2021

https://github.com/lerna/lerna#independent-mode

The intention is for a @webref/css package to be versioned independently
of @webref/idl. In the meantime, this avoids two places for the same
version.

https://github.com/lerna/lerna#independent-mode

The intention is for a @webref/css package to be versioned independently
of @webref/idl. In the meantime, this avoids two places for the same
version.
@foolip
Copy link
Member Author

foolip commented Feb 12, 2021

There's a consequence of this which is worth pointing out. In the default mode, all packages get the same version, and npx lerna version patch would create a tag called v1.0.1. With independent mode, each package would get its own tag, so we'd get @webref/idl@1.0.1 instead.

@dontcallmedom @tidoust do you think we should tag the releases at all? If so do you care if there are more tags in total? There is something to be said for the scoped tags, since it's not webref itself which will be at v1.0.1.

@foolip

This comment has been minimized.

@foolip
Copy link
Member Author

foolip commented Feb 12, 2021

Regarding tagging, I went ahead and retroactively tagged @webref/idl@1.0.0 on the branch which used to release. I can delete it again if you'd rather not have any tags for releases.

Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to have tags per package release.

@tidoust tidoust merged commit 1c0bf44 into w3c:master Feb 12, 2021
@foolip foolip deleted the lerna-independent branch February 12, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants