Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldTriggerKeyFrame flag is set backwards #183

Closed
docfaraday opened this issue Jun 2, 2023 · 1 comment · Fixed by #196
Closed

shouldTriggerKeyFrame flag is set backwards #183

docfaraday opened this issue Jun 2, 2023 · 1 comment · Fixed by #196

Comments

@docfaraday
Copy link

This language appears to be backwards.

"Let shouldTriggerKeyFrame be true if encoder.[[pendingKeyFrameTasks]] contains a task whose [[rid]] value is equal to rid, and false otherwise."

This will set shouldTriggerKeyFrame to false if this is the first generateKeyFrame call for the rid (which means that the first call does not do anything), and true if there are already previous requests.
@youennf
Copy link
Collaborator

youennf commented Jul 5, 2023

Right, will fix this

youennf added a commit to youennf/webrtc-insertable-streams that referenced this issue Jul 5, 2023
@youennf
shouldTriggerKeyFrame flag is set backwards.
38ed20b 
Reverse the value to make it right.

Fixes w3c#183.
@youennf youennf mentioned this issue Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shouldTriggerKeyFrame flag is set backwards. youennf/webrtc-insertable-streams
2 participants
@docfaraday @youennf