describe (some) fields #155
Conversation
fippo
force-pushed
the
describe-all-the-things
branch
3 times, most recently
from
4e3c03f
to
76fcd19
Compare
fippo
force-pushed
the
describe-all-the-things
branch
from
76fcd19
to
a998526
Compare
|
@dontcallmedom any idea why https://pr-preview.s3.amazonaws.com/fippo/webrtc-media-streams/pull/155.html#RTCEncodedAudioFrameMetadata-members looks more BOLD and larger? I might be missing some CSS magic.. |
Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
|
actually the not-so-nice display seems to be a preview issue, also happens for stats. I think this should be ok. |
fippo
force-pushed
the
describe-all-the-things
branch
4 times, most recently
from
16cbe3d
to
0eff049
Compare
| @@ -264,6 +264,7 @@ The <dfn method for="SFrameTransform">setEncryptionKey(|key|, |keyID|)</dfn> met | |||
|
|
|||
| # RTCRtpScriptTransform # {#scriptTransform} | |||
|
|
|||
| ## <dfn>RTCEncodedVideoFrameType</dfn> dictionary ## {#RTCEncodedVideoFrameType} | |||
There was a problem hiding this comment.
We probably want to replace RTCEncodedVideoFrameType by EncodedVideoFrameType, expect if there is a use for "empty".
That would remove the need for the below added section.
There was a problem hiding this comment.
empty seems to be used when the underlying frame is gone (i.e. after enqueing?).
I think that should be handled differently
There was a problem hiding this comment.
Ah, interesting. This is a difference between Safari and Chrome I guess.
It might be worth its own GitHub issue. If we align with Chrome, the enqueue algorithm should detail this.
| ### Members ### {#RTCEncodedAudioFrameMetadata-members} | ||
| <dl data-link-for="RTCEncodedAudioFrameMetadata" | ||
| data-dfn-for="RTCEncodedAudioFrameMetadata" | ||
| class="dictionary-members"> |
There was a problem hiding this comment.
If we anticipate to add more metadata common to video and audio, we might want to introduce a RTCEncodedFrameMetata dictionary that audio and video metadata dictionaries would extend.
Let's think about this once this PR is done.
fippo
force-pushed
the
describe-all-the-things
branch
from
0eff049
to
565a209
Compare
fippo
force-pushed
the
describe-all-the-things
branch
from
6b1b7b9
to
912fa3e
Compare
|
The argument in favor of the ugly HTML is that it is consistent with stats (hopefully also visually but we'll only see after merging I think). Now that it is there i expect this to be just copy-pasted on additions. |
SHA: c85fc84 Reason: push, by aboba Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
html taken from webrtc-stats, lets see how this renders...
Preview | Diff