Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serializable attributes to encoded video frames #182

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

alvestrand
Copy link
Contributor

@alvestrand alvestrand commented Jun 2, 2023

Fixes #181


Preview | Diff

@alvestrand alvestrand mentioned this pull request Jun 7, 2023
@alvestrand
Copy link
Contributor Author

This may need adding serializer / deserializer steps, which didn't exist before.

@dontcallmedom-bot
Copy link

This issue was mentioned in WEBRTCWG-2023-09-12 (Page 49)

@alvestrand
Copy link
Contributor Author

Updated with serialization steps as discussed at TPAC 2023. @jan-ivar please take a look.
(Yes, there's more bikeshed-y linkage that can be added.)

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
@henbos
Copy link
Collaborator

henbos commented Sep 22, 2023

I recall we decided to put editors can integrate on this PR yesterday? Adding

@alvestrand alvestrand merged commit 09f618e into main Sep 22, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Sep 22, 2023
SHA: 09f618e
Reason: push, by alvestrand

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@alvestrand alvestrand deleted the alvestrand-patch-1 branch September 22, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EncodedVideoFrame needs to be marked serializable
5 participants