Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/NotAllowedError/TypeError for invalid rid & reference RFC8851. #193

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Jun 29, 2023

Fixes #192


Preview | Diff

@youennf
Copy link
Collaborator

youennf commented Jun 29, 2023

Sounds good, if we ever constrain further rid size to 16 as suggested in w3c/webrtc-pc#2732, we might need to update both this spec and webrtc-pc

index.bs Outdated Show resolved Hide resolved
@youennf youennf merged commit 4bd0792 into main Jun 29, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Jun 29, 2023
SHA: 4bd0792
Reason: push, by youennf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underspecified rid checking in sender.generateKeyFrame(["x"]); shouldn't throw NotAllowedError
2 participants