Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header extension control: spec text inconsistent with RFC5285 section 6. #60

Closed
handellm opened this issue Dec 18, 2020 · 3 comments · Fixed by #62
Closed

Header extension control: spec text inconsistent with RFC5285 section 6. #60

handellm opened this issue Dec 18, 2020 · 3 comments · Fixed by #62

Comments

@handellm
Copy link

In the algorithm for generating subsequent offers in [RTCWEB-JSEP] section 5.2.2, replace "The RTP header extensions MUST only include those that are present in the most recent answer" with "For each RTP header extension listed in [[HeaderExtensionsToOffer]] that is also present in the most recent answer, and where direction is not "stopped", generate an appropriate "a=extmap" line with "direction" set according to the rules of [RFC5285] section 6, considering the direction in [[HeaderExtensionsToOffer]] to indicate the answerer's desired usage". This preserves the property that the set of extensions may not grow with subsequent offers."

But RFC5285, section 6 says:

A session update MAY add or remove extension(s)

Given that extmap-allow-mixed is now turning default as of https://webrtc-review.googlesource.com/c/src/+/197943, there's soon no crisis anymore with the number of header extensions in use. I propose we drop the restriction.

@handellm
Copy link
Author

Also note https://chromium-review.googlesource.com/c/chromium/src/+/2596147.
Friendly ping :)

@alvestrand
Copy link
Collaborator

I think we should just do this. This extension is already modifying JSEP's language, we should modify it some more.

@juberti
Copy link

juberti commented Jan 14, 2021

Here's some of the underlying rationale for the JSEP logic, FWIW. This particular part applies to PT selection but the same may also apply to header extension ID selection. rtcweb-wg/jsep#266 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants