Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-calling Start: Changed parameters confused? #18

Open
alvestrand opened this issue Aug 14, 2018 · 2 comments
Open

Re-calling Start: Changed parameters confused? #18

alvestrand opened this issue Aug 14, 2018 · 2 comments
Labels

Comments

@alvestrand
Copy link
Collaborator

The following text:

  1. If start() is called again but the value of remoteParameters has changed, local candidates are kept, remote candidates are flushed, candidate pairs are flushed and state transitions to new.
    ....
  2. If start() is called again with new values of remoteParameters, local candidates are flushed, remote candidates are flushed, candidate pairs are flushed and state transitions to new.

leaves me scratching my head about what the difference is between "with new values of remoteParameters" and "the value of remoteParameters has changed".

The difference in result is whether or not local candidates are flushed. Should the "remoteParameters" in 9 be "local parameters"?

@steveanton
Copy link
Collaborator

I think this is an artifact of the copy-and-paste from ORTC's RTCIceTransport. In ORTC, start also takes an RTCIceGatherer and steps 8 & 9 specify what happens if the gatherer changes (i.e., flush local candidates).

So I think the right course of action is to remove steps 8 & 9 from start.

@aboba
Copy link
Contributor

aboba commented Aug 16, 2018

In ORTC, step 8 has the same RTCIceGatherer, but step 9 has a new one (implying a new generation).

In WebRTC-ICE what are the circumstances in which an ICE restart can occur without creating a new RTCIceTransport? Does calling gather again ever result in a new generation?

@aboba aboba added the question label Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants