Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move webrtc-pc's identity handling steps and constructs here. #30

Merged
merged 7 commits into from Dec 6, 2019
Merged

Move webrtc-pc's identity handling steps and constructs here. #30

merged 7 commits into from Dec 6, 2019

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Dec 4, 2019 •
edited by pr-preview bot

Fixes w3c/webrtc-pc#2364. Contains everything from w3c/webrtc-pc#2390.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Dec 4, 2019
This was referenced Dec 4, 2019
Closed
Merged
martinthomson
martinthomson approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem like the right changes; I didn't see any problems with the moved text, though I would request that you look at the capitalization of headings. It's now inconsistent, even within these changes.

identity.html Outdated Show resolved Hide resolved
identity.html Outdated Show resolved Hide resolved
jan-ivar and others added 3 commits December 4, 2019 09:40
@jan-ivar @martinthomson
Consistently Capitalize
4a37e35 
Co-Authored-By: Martin Thomson <mt@lowentropy.net>
@jan-ivar @martinthomson
Consistently Capitalize
6cbbe72 
Co-Authored-By: Martin Thomson <mt@lowentropy.net>
@jan-ivar
Consistently shim and Capitalize.
9c014d0
henbos
henbos approved these changes Dec 5, 2019
View reviewed changes
identity.html Outdated Show resolved Hide resolved
@jan-ivar
Copy link
Member Author

jan-ivar commented Dec 6, 2019

This move is tied to w3c/webrtc-pc#2390 which is now ready to merge and has the Editors can integrate label, so I'm merging this first.

@jan-ivar jan-ivar merged commit a7313a3 into master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henbos henbos henbos approved these changes

@martinthomson martinthomson martinthomson approved these changes

@youennf youennf Awaiting requested review from youennf

Assignees

@jan-ivar jan-ivar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move identity steps to the identity spec
3 participants
@jan-ivar @martinthomson @henbos