Skip to content

Commit

Permalink
Merge pull request #2861 from jan-ivar/dtmfplayoutcheck
Browse files Browse the repository at this point in the history
Determine if DTMF can be sent inside queued playout task.
  • Loading branch information
henbos committed Apr 27, 2023
2 parents dff784d + 695d640 commit 2ce2e4a
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
9 changes: 9 additions & 0 deletions amendments.json
Original file line number Diff line number Diff line change
Expand Up @@ -476,5 +476,14 @@
"status": "candidate",
"id": 32
}
],
"dtmf-playout-check": [
{
"description": "Determine if DTMF can be sent inside queued playout task",
"pr": 2861,
"type": "correction",
"status": "candidate",
"id": 33
}
]
}
2 changes: 1 addition & 1 deletion base-rec.html
Original file line number Diff line number Diff line change
Expand Up @@ -14819,7 +14819,7 @@ <h4 id="methods-13">
steps; otherwise queue a task that runs the following steps
(<em>Playout task</em>):
<ol>
<li>If
<li id="dtmf-playout-check">If
<var>transceiver</var>.<a href="#dfn-currentdirection" class="internalDFN" data-link-type="dfn" id="ref-for-dfn-currentdirection-8">[[CurrentDirection]]</a> is
neither "<a data-link-type="idl" href="#dom-rtcrtptransceiverdirection-sendrecv" class="internalDFN" id="ref-for-dom-rtcrtptransceiverdirection-sendrecv-20"><code><code>sendrecv</code></code></a>" nor
"<a data-link-type="idl" href="#dom-rtcrtptransceiverdirection-sendonly" class="internalDFN" id="ref-for-dom-rtcrtptransceiverdirection-sendonly-15"><code><code>sendonly</code></code></a>", abort these
Expand Down
6 changes: 2 additions & 4 deletions webrtc.html
Original file line number Diff line number Diff line change
Expand Up @@ -15097,10 +15097,8 @@ <h2>
steps; otherwise queue a task that runs the following steps
(<em>Playout task</em>):
<ol>
<li>If
<var>transceiver</var>.{{RTCRtpTransceiver/[[CurrentDirection]]}} is
neither {{RTCRtpTransceiverDirection/"sendrecv"}} nor
{{RTCRtpTransceiverDirection/"sendonly"}}, abort these
<li id="dtmf-playout-check">If [=determine if DTMF can be sent=] for
<var>dtmf</var> returns <code>false</code>, abort these
steps.
</li>
<li>If the {{RTCDTMFSender/[[ToneBuffer]]}} slot contains the empty
Expand Down

0 comments on commit 2ce2e4a

Please sign in to comment.