Skip to content

Commit

Permalink
Merge pull request #2040 from jan-ivar/addnull
Browse files Browse the repository at this point in the history
Allow addIceCandidate(null) again for backwards comp and symmetry.
  • Loading branch information
alvestrand committed Dec 11, 2018
2 parents 66678f6 + 1f50e71 commit 75333c8
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions webrtc.html
Expand Up @@ -2882,7 +2882,9 @@ <h2>Methods</h2>
method was invoked.</p>
</li>
<li>
<p>If both <var>sdpMid</var> and <var>sdpMLineIndex</var> are
<p>If <var>candidate.candidate</var> is not an empty string
and both <var>candidate.sdpMid</var> and
<var>candidate.sdpMLineIndex</var> are
<code>null</code>, return a promise <a>rejected</a> with a newly
<a data-link-for="exception" data-lt="create">created</a>
<code>TypeError</code>.</p>
Expand Down Expand Up @@ -2956,7 +2958,9 @@ <h2>Methods</h2>
string, process <var>candidate</var> as an
end-of-candidates indication for the corresponding
<a>media description</a> and ICE candidate
<a>generation</a>.</p>
<a>generation</a>. If both <var>candidate.sdpMid</var> and
<var>candidate.sdpMLineIndex</var> are <code>null</code>, then
this applies to all <a>media description</a>s.</p>
<ol>
<li>
<p>If <var>candidate</var> could not be
Expand Down Expand Up @@ -3012,6 +3016,11 @@ <h2>Methods</h2>
</ol>
</li>
</ol>
<p class="note">Due to WebIDL processing, addIceCandidate(null)
is interpreted as a call with the default dictionary present, which, in the
above algorithm, indicates end-of-candidates for all media
descriptions and ICE candidate generation. This is by design for
legacy reasons.</p>
</dd>
<dt><dfn data-idl><code>getDefaultIceServers</code></dfn></dt>
<dd>
Expand Down

0 comments on commit 75333c8

Please sign in to comment.