Skip to content

Commit

Permalink
Describe changes as amendments
Browse files Browse the repository at this point in the history
  • Loading branch information
dontcallmedom committed Mar 6, 2023
1 parent 9e90e01 commit cd77ef6
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 5 deletions.
27 changes: 27 additions & 0 deletions amendments.json
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,13 @@
"type": "correction",
"status": "candidate",
"id": 24
},
{
"description": "Reject setParameters(), replaceTrack(), & insertDTMF() after stop()",
"pr": 2829,
"type": "correction",
"status": "candidate",
"id": 29
}
],
"create-sender-algo": [
Expand Down Expand Up @@ -422,5 +429,25 @@
"status": "candidate",
"id": 28
}
],
"replacetrack-reject": [
{
"description": "Reject setParameters(), replaceTrack(), & insertDTMF() after stop()",
"pr": 2829,
"type": "correction",
"status": "candidate",
"id": 29
}
],
"dtmf-stopping": [
{
"description": "Reject setParameters(), replaceTrack(), & insertDTMF() after stop()",
"pr": 2829,
"difftype": "append",
"type": "correction",
"status": "candidate",
"id": 29
}

]
}
4 changes: 2 additions & 2 deletions base-rec.html
Original file line number Diff line number Diff line change
Expand Up @@ -9327,7 +9327,7 @@ <h4 id="methods-6">
to <var>connection</var>'s <a data-link-type="dfn" href="#dfn-operations-chain" class="internalDFN" id="ref-for-dfn-operations-chain-9">operations chain</a>:
</p>
<ol>
<li data-tests="RTCPeerConnection-setRemoteDescription-replaceTrack.https.html,RTCRtpSender-replaceTrack.https.html,RTCRtpTransceiver.https.html" class="has-tests">
<li data-tests="RTCPeerConnection-setRemoteDescription-replaceTrack.https.html,RTCRtpSender-replaceTrack.https.html,RTCRtpTransceiver.https.html" class="has-tests" id="replacetrack-reject">
<p>
If <var>transceiver</var>.<a href="#dfn-stopped-0" class="internalDFN" data-link-type="dfn" id="ref-for-dfn-stopped-0-9">[[Stopped]]</a> is
<code>true</code>, return a promise <a data-link-type="dfn" href="#dfn-reject" class="internalDFN" id="ref-for-dfn-reject-43">rejected</a>
Expand Down Expand Up @@ -14889,7 +14889,7 @@ <h3 id="x7-3-caninsertdtmf-algorithm"><bdi class="secno">7.3 </bdi>
<li class="no-test-needed">Let <var>connection</var> be the
<a data-link-type="idl" href="#dom-rtcpeerconnection" class="internalDFN" id="ref-for-dom-rtcpeerconnection-131"><code><code>RTCPeerConnection</code></code></a> associated with <var>transceiver</var>.
</li>
<li class="needs-tests">If <var>connection</var>'s <a data-link-type="idl" href="#dom-rtcpeerconnectionstate" class="internalDFN" id="ref-for-dom-rtcpeerconnectionstate-6"><code><code>RTCPeerConnectionState</code></code></a> is not
<li id="dtmf-stopping" class="needs-tests">If <var>connection</var>'s <a data-link-type="idl" href="#dom-rtcpeerconnectionstate" class="internalDFN" id="ref-for-dom-rtcpeerconnectionstate-6"><code><code>RTCPeerConnectionState</code></code></a> is not
"<a data-link-type="idl" href="#dom-rtcpeerconnectionstate-connected" class="internalDFN" id="ref-for-dom-rtcpeerconnectionstate-connected-2"><code><code>connected</code></code></a>" return <code>false</code>.
</li>
<li class="needs-tests">If <var>sender</var>.<a href="#dfn-sendertrack" class="internalDFN" data-link-type="dfn" id="ref-for-dfn-sendertrack-8">[[SenderTrack]]</a> is <code>null</code>
Expand Down
6 changes: 3 additions & 3 deletions webrtc.html
Original file line number Diff line number Diff line change
Expand Up @@ -9255,7 +9255,7 @@ <h2>
to <var>connection</var>'s [= operations chain =]:
</p>
<ol>
<li data-tests=
<li id="replacetrack-reject" data-tests=
"RTCPeerConnection-setRemoteDescription-replaceTrack.https.html,RTCRtpSender-replaceTrack.https.html,RTCRtpTransceiver.https.html">
<p>
If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopping]]}} is
Expand Down Expand Up @@ -15079,10 +15079,10 @@ <h3>
<li class="no-test-needed">Let <var>connection</var> be the
{{RTCPeerConnection}} associated with <var>transceiver</var>.
</li>
<li>If <var>connection</var>'s {{RTCPeerConnectionState}} is not
<li id="dtmf-stopping">If <var>connection</var>'s {{RTCPeerConnectionState}} is not
{{RTCPeerConnectionState/"connected"}} return <code>false</code>.
</li>
<li>If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopping]]}} is
<li class="add-to-dtmf-stopping">If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopping]]}} is
<code>true</code> return <code>false</code>.
</li>
<li>If <var>sender</var>.{{RTCRtpSender/[[SenderTrack]]}} is <code>null</code>
Expand Down

0 comments on commit cd77ef6

Please sign in to comment.