Merge pull request #2829 from jan-ivar/rejectstopping

setParameters(), replaceTrack(), & insertDTMF() reject after stop().
w3c · Apr 3, 2023 · fb2be18 · fb2be18
2 parents c3e196e + d7b7183
commit fb2be18
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 6 deletions.
diff --git a/amendments.json b/amendments.json
@@ -280,6 +280,13 @@
       "type": "correction",
       "status": "candidate",
       "id": 24
+    },
+    {
+      "description": "Reject setParameters(), replaceTrack(), & insertDTMF() after stop()",
+      "pr": 2829,
+      "type": "correction",
+      "status": "candidate",
+      "id": 32
     }
   ],
   "create-sender-algo": [
@@ -450,5 +457,24 @@
       "difftype": "append",
       "id": 31
     }
+  ],
+  "replacetrack-reject": [
+    {
+      "description": "Reject setParameters(), replaceTrack(), & insertDTMF() after stop()",
+      "pr": 2829,
+      "type": "correction",
+      "status": "candidate",
+      "id": 32
+    }
+  ],
+  "dtmf-stopping": [
+    {
+      "description": "Reject setParameters(), replaceTrack(), & insertDTMF() after stop()",
+      "pr": 2829,
+      "difftype": "append",
+      "type": "correction",
+      "status": "candidate",
+      "id": 32
+    }
   ]
 }
diff --git a/base-rec.html b/base-rec.html
@@ -9327,7 +9327,7 @@ <h4 id="methods-6">
                       to <var>connection</var>'s <a data-link-type="dfn" href="#dfn-operations-chain" class="internalDFN" id="ref-for-dfn-operations-chain-9">operations chain</a>:
                     </p>
                     <ol>
-                      <li data-tests="RTCPeerConnection-setRemoteDescription-replaceTrack.https.html,RTCRtpSender-replaceTrack.https.html,RTCRtpTransceiver.https.html" class="has-tests">
+                      <li data-tests="RTCPeerConnection-setRemoteDescription-replaceTrack.https.html,RTCRtpSender-replaceTrack.https.html,RTCRtpTransceiver.https.html" class="has-tests" id="replacetrack-reject">
                         <p>
                           If <var>transceiver</var>.<a href="#dfn-stopped-0" class="internalDFN" data-link-type="dfn" id="ref-for-dfn-stopped-0-9">[[Stopped]]</a> is
                           <code>true</code>, return a promise <a data-link-type="dfn" href="#dfn-reject" class="internalDFN" id="ref-for-dfn-reject-43">rejected</a>
@@ -14890,7 +14890,7 @@ <h3 id="x7-3-caninsertdtmf-algorithm"><bdi class="secno">7.3 </bdi>
           <li class="no-test-needed">Let <var>connection</var> be the
           <a data-link-type="idl" href="#dom-rtcpeerconnection" class="internalDFN" id="ref-for-dom-rtcpeerconnection-131"><code><code>RTCPeerConnection</code></code></a> associated with <var>transceiver</var>.
           </li>
-          <li class="needs-tests">If <var>connection</var>'s <a data-link-type="idl" href="#dom-rtcpeerconnectionstate" class="internalDFN" id="ref-for-dom-rtcpeerconnectionstate-6"><code><code>RTCPeerConnectionState</code></code></a> is not
+          <li id="dtmf-stopping" class="needs-tests">If <var>connection</var>'s <a data-link-type="idl" href="#dom-rtcpeerconnectionstate" class="internalDFN" id="ref-for-dom-rtcpeerconnectionstate-6"><code><code>RTCPeerConnectionState</code></code></a> is not
           "<a data-link-type="idl" href="#dom-rtcpeerconnectionstate-connected" class="internalDFN" id="ref-for-dom-rtcpeerconnectionstate-connected-2"><code><code>connected</code></code></a>" return <code>false</code>.
           </li>
           <li class="needs-tests">If <var>sender</var>.<a href="#dfn-sendertrack" class="internalDFN" data-link-type="dfn" id="ref-for-dfn-sendertrack-8">[[SenderTrack]]</a> is <code>null</code>

diff --git a/webrtc.html b/webrtc.html
@@ -8959,7 +8959,7 @@ <h2>
                   </li>
                   <li data-tests=
                   "RTCRtpSender-setParameters.html,RTCRtpTransceiver.https.html">
-                  If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopped]]}} is
+                  If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopping]]}} is
                   <code>true</code>, return a promise [= rejected =] with a
                   newly [= exception/created =] {{InvalidStateError}}.
                   </li>
@@ -9273,10 +9273,10 @@ <h2>
                       to <var>connection</var>'s [= operations chain =]:
                     </p>
                     <ol>
-                      <li data-tests=
+                      <li id="replacetrack-reject" data-tests=
                       "RTCPeerConnection-setRemoteDescription-replaceTrack.https.html,RTCRtpSender-replaceTrack.https.html,RTCRtpTransceiver.https.html">
                         <p>
-                          If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopped]]}} is
+                          If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopping]]}} is
                           <code>true</code>, return a promise [= rejected =]
                           with a newly [= exception/created =]
                           {{InvalidStateError}}.
@@ -15107,9 +15107,12 @@ <h3>
           <li class="no-test-needed">Let <var>connection</var> be the
           {{RTCPeerConnection}} associated with <var>transceiver</var>.
           </li>
-          <li>If <var>connection</var>'s {{RTCPeerConnectionState}} is not
+          <li id="dtmf-stopping">If <var>connection</var>'s {{RTCPeerConnectionState}} is not
           {{RTCPeerConnectionState/"connected"}} return <code>false</code>.
           </li>
+          <li class="add-to-dtmf-stopping">If <var>transceiver</var>.{{RTCRtpTransceiver/[[Stopping]]}} is
+          <code>true</code> return <code>false</code>.
+          </li>
           <li>If <var>sender</var>.{{RTCRtpSender/[[SenderTrack]]}} is <code>null</code>
           return <code>false</code>.
           </li>