Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"track" event shouldn't fire for a "recvonly" description. #1013

Closed
taylor-b opened this issue Feb 4, 2017 · 1 comment
Closed

"track" event shouldn't fire for a "recvonly" description. #1013

taylor-b opened this issue Feb 4, 2017 · 1 comment

Comments

@taylor-b
Copy link
Contributor

taylor-b commented Feb 4, 2017

This is something I'm pretty confident we decided previously. Consider the legacy addTrack use case, where PeerConnection A adds a track, but PeerConnection B doesn't, and they do an offer/answer exchange. The "track" event should fire for B, but not for A. Later, if B calls addTrack, and they do another offer/answer, the direction will change and the "track" event will fire for A.

But currently, the "dispatch a receiver" steps will unconditionally fire the "track" event for every new "m=" section.

@aboba
Copy link
Contributor

aboba commented Feb 6, 2017

@taylor-b It would be weird to fire a "track" event when in fact there is no incoming track. Can you submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants