Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that "track" event is only fired for "send" direction m-sections. #1016

Merged
merged 2 commits into from Feb 9, 2017

Conversation

taylor-b
Copy link
Contributor

@taylor-b taylor-b commented Feb 7, 2017

Fixes #1013

Also does a bit of refactoring. The steps that used to be listed in the
"dispatch a receiver" section are now covered by "create a receiver" and
"stop a transceiver".

Also does a bit of refactoring. The steps that used to be listed in the
"dispatch a receiver" section are now covered by "create a receiver" and
"stop a transceiver".
Copy link
Contributor

@aboba aboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is most of the text in lines 4927 - 4967 and 4987-5022 contained elsewhere so it is redundant? Trying to understand if all the steps described in that text are still covered once this material is deleted.

@taylor-b
Copy link
Contributor Author

taylor-b commented Feb 8, 2017

@aboba That's what it seemed to me.

The "dispatch a receiver" steps for creating a track were identical to those in "create a receiver".

And the steps for "when a track is removed" are covered by the transceiver being stopped. This is the only time when a track should go to "ended", since that's a terminal state, and stopping a transceiver is the only terminal thing for its RtpReceiver. The differences I see are:

  • The previous text mentioned that "an event" is fired when the track state goes to "ended". It looks like this is missing from the "stop a transceiver" steps; I'll add it.
  • A task is queued to remove the receiver from the "set of receivers". This is no longer relevant here; there's a "set of transceivers" instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants