Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Callback definitions" section should go under "legacy interface extensions" #1142

Closed
taylor-b opened this issue Apr 24, 2017 · 2 comments · Fixed by #1143
Closed

"Callback definitions" section should go under "legacy interface extensions" #1142

taylor-b opened this issue Apr 24, 2017 · 2 comments · Fixed by #1143
Labels
Editorial

Comments

@taylor-b
Copy link
Contributor

... Since these callbacks are only used for the legacy interface extensions.

Also, RTCStatsCallback is not referenced anywhere. Did we forget to add a legacy getStats method? Or can we just remove RTCStatsCallback?
fippo added a commit to fippo/webrtc-pc that referenced this issue Apr 24, 2017
@fippo
move legacy callback definitions to legacy section
ef2a335 
fixes w3c#1142
@fippo fippo mentioned this issue Apr 24, 2017
Merged
@fippo
Copy link
Contributor

fippo commented Apr 24, 2017

i'd prefer to remove it but then users of the legacy interface extensions will have to use a promise-based getStats.

@taylor-b
Copy link
Contributor Author

It looks like we already decided to get rid of the legacy getStats, since there wasn't an interoperable legacy implementation in the first place. #924

@ddbeck ddbeck mentioned this issue Mar 8, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move legacy callback definitions to legacy section fippo/webrtc-pc
2 participants
@fippo @taylor-b