Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending data channel messages > maxMessageSize #1205

Closed
lgrahl opened this issue May 11, 2017 · 2 comments
Closed

Sending data channel messages > maxMessageSize #1205

lgrahl opened this issue May 11, 2017 · 2 comments
Assignees

Comments

@lgrahl
Copy link
Contributor

lgrahl commented May 11, 2017

The maxMessageSize attribute of the RTCSctpTransport interface describes maxMessageSize as

The maximum size of data that can be passed to RTCDataChannel 's send() method.

  1. The RTCDataChannel.send method doesn't mention maxMessageSize in its description. This probably needs updating. (resolved by Throw error if data channel's buffer is filled, rather than closing. #1209)
  2. We need to know exactly what an implementation is supposed to do in case a message is larger than maxMessageSize. I'm suggesting to throw an exception. (resolved by Throw error if data channel's buffer is filled, rather than closing. #1209)
  3. The spec should make clear that maxMessageSize refers to the maximum message size the other peer is able to receive.

Link to the corresponding SDP spec section

@lgrahl
Copy link
Contributor Author

lgrahl commented Jun 1, 2017

  1. should probably depend on the outcome of Section 6.2: when data cannot be sent #1287. I'd appreciate having explicit fails in the API rather than implicit fails by closing the data channel.

@lgrahl
Copy link
Contributor Author

lgrahl commented Jun 17, 2017

1 and 2 have been resolved by #1209. Only 3 is left. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants