Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section 6.2: when data cannot be sent #1287

Closed
aboba opened this issue May 31, 2017 · 2 comments
Closed

Section 6.2: when data cannot be sent #1287

aboba opened this issue May 31, 2017 · 2 comments
Assignees
@taylor-b
Labels
PR exists

Comments

@aboba
Copy link
Contributor

aboba commented May 31, 2017 •
edited

From EKR: https://lists.w3.org/Archives/Public/public-webrtc/2017May/0166.html

5. Attempt to send data on channel's underlying data transport; if
the data cannot be sent, e.g. because it would need to be buffered
but the buffer is full, the user agent must abruptly close
channel's underlying data transport with an error.

This seems like a very unsafe API. Why not instead have it fail?
@aboba aboba changed the title Section 6.2 Section 6.2: when data cannot be sent May 31, 2017
@lgrahl
Copy link
Contributor

lgrahl commented Jun 1, 2017

I agree that letting it fail makes much more sense.

@lgrahl lgrahl mentioned this issue Jun 1, 2017
Closed
@aboba aboba mentioned this issue Jun 8, 2017
Merged
@aboba
Copy link
Contributor Author

aboba commented Jun 8, 2017 •
edited

Related Issue: #1148
Related PR: #1209

@aboba aboba added the PR exists label Jun 8, 2017
@aboba aboba closed this as completed Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taylor-b taylor-b

Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aboba @lgrahl @taylor-b