Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 6.4: Datachannel Garbage Collection #1288

Closed
aboba opened this issue May 31, 2017 · 4 comments
Closed

Section 6.4: Datachannel Garbage Collection #1288

aboba opened this issue May 31, 2017 · 4 comments
Assignees

Comments

@aboba
Copy link
Contributor

aboba commented May 31, 2017

From EKR: https://lists.w3.org/Archives/Public/public-webrtc/2017May/0166.html

You seem to be saying that I can't garbage collect the data channel as long as the SCTP connection is up even if the PC is closed? that seems surprising.

@aboba
Copy link
Contributor Author

aboba commented May 31, 2017

@ekr pc.close() is missing a step. It should close the data channels, but it doesn't seem to:
https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#dom-rtcpeerconnection-close

@aboba aboba self-assigned this May 31, 2017
@aboba
Copy link
Contributor Author

aboba commented May 31, 2017

Calling pc.close() seems like it should invoke the data channel close procedure (as though RTCDataChannel.close() were called):

When the close method is called, the user agent must run the following steps:

Let channel be the RTCDataChannel object which is about to be closed.

If channel's readyState is closing or closed, then abort these steps.

Set channel's readyState attribute to closing.

If the closing procedure has not started yet, start it.

@aboba
Copy link
Contributor Author

aboba commented Jun 13, 2017

Related Issue: #1381

@aboba aboba assigned aboba and unassigned adam-be Jun 14, 2017
@aboba aboba assigned adam-be and unassigned aboba Jun 28, 2017
aboba added a commit that referenced this issue Oct 5, 2017
Work in progress, do not merge.

Fix for Issues #1288, #1381 and #1612 ,
aboba added a commit that referenced this issue Oct 5, 2017
Work in progress, do not merge.

Fix for Issues #1288 and #1381
@adam-be
Copy link
Member

adam-be commented Nov 2, 2017

I believe this issue can be closed (fixed by #1621)

@adam-be adam-be closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants