Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly incorrect language in "generateCertificate" description #1324

Closed
rwaldron opened this issue Jun 1, 2017 · 1 comment
Closed

Possibly incorrect language in "generateCertificate" description #1324

rwaldron opened this issue Jun 1, 2017 · 1 comment
Assignees
@aboba
Labels
Editorial PR exists

Comments

@rwaldron
Copy link

rwaldron commented Jun 1, 2017

These objects can be explicitly generated by applications using the generateCertificate method on the connection and provided in the RTCConfiguration when constructing a new RTCPeerConnection instance

(emphasis mine)

I'm not sure what the bold section actually means, since generateCertificate is not a method of a connection object.
aboba added a commit that referenced this issue Jun 1, 2017
@aboba
Language in "generateCertificate" description
2ce8953 
Fix for Issue #1324
@aboba aboba mentioned this issue Jun 1, 2017
Merged
@aboba aboba self-assigned this Jun 1, 2017
taylor-b pushed a commit that referenced this issue Jun 8, 2017
@aboba @taylor-b
Language in "generateCertificate" description (#1325)
0aa6115 
Fix for Issue #1324
@aboba aboba closed this as completed Jun 8, 2017
@rwaldron
Copy link
Author

rwaldron commented Jun 8, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aboba aboba

Labels
Editorial PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwaldron @aboba