Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: consistent Internal slot names e.g. [[IsClosed]] vs [[isClosed]]? #1360

Closed
jan-ivar opened this issue Jun 8, 2017 · 2 comments
Closed

Editorial: consistent Internal slot names e.g. [[IsClosed]] vs [[isClosed]]? #1360

jan-ivar opened this issue Jun 8, 2017 · 2 comments
Assignees
@adam-be
Labels
Editorial

Comments

@jan-ivar
Copy link
Member

jan-ivar commented Jun 8, 2017

I can't find a TAG link for this, just cargo-culting from the html and webidl specs. Seems less likely to name clash with API names as well.

I'm filing this issue rather than asking for internal consistency in #1321 review.
@jan-ivar jan-ivar changed the title Internal slot names should have capital first char e.g. [[IsClosed]] not [[isClosed]] Editorial: Internal slot names should be capital 1st e.g. [[IsClosed]] not [[isClosed]] Jun 8, 2017
@jan-ivar jan-ivar mentioned this issue Jun 8, 2017
Merged
@jan-ivar jan-ivar changed the title Editorial: Internal slot names should be capital 1st e.g. [[IsClosed]] not [[isClosed]] Editorial: consistent Internal slot names e.g. [[IsClosed]] vs [[isClosed]]? Jun 21, 2017
@jan-ivar
Copy link
Member Author

Apparently slot names are fairly ad hoc atm. but we should at least make them consistent within the same spec.

@burnburn burnburn mentioned this issue Jun 22, 2017
Merged
@aboba
Copy link
Contributor

aboba commented Jun 22, 2017

Note: Dom suggests Capitalized Case.

@aboba aboba closed this as completed Jun 29, 2017
@fippo fippo mentioned this issue Jun 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-be adam-be

Labels
Editorial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aboba @adam-be @jan-ivar