move "set a configuration" algorithm #1233
Conversation
|
This is very hard to review. I'd prefer to do this as two separate PRs - one that just moves the text with no changes to it, and a second that makes any changes. |
|
i'll try to separate the commits again |
|
@fippo can you separate commits? |
fippo
force-pushed
the
move-setconfiguration
branch
from
f89d4ba
to
66c6485
Compare
|
done and squashed/rebased. Old branch/commit is retained here . Sorry for taking so long, had to make sure iprbot still 💕 me. |
fippo
force-pushed
the
move-setconfiguration
branch
from
66c6485
to
14ff3e2
Compare
|
@fippo Sorry to be picky, but can you separate this into separate PRs as well, so it's easier to review the diff? |
|
Aside from the comment above, and the fact that there are merge conflicts now (sorry), this LGTM |
fippo
force-pushed
the
move-setconfiguration
branch
from
14ff3e2
to
d222257
Compare
|
hold on, there still seem to be merge conflicts... |
fippo
force-pushed
the
move-setconfiguration
branch
from
d222257
to
67b7f86
Compare
|
rebased, kept the same commit structure, fixed the throw in the respec commit and added another commit that makes the internal slot consistent with #1360 |
webrtc.html
Outdated
| @@ -1022,7 +1022,8 @@ | |||
| <p>Initialize <var>connection</var>'s <a>ICE Agent</a>.</p> | |||
| </li> | |||
| <li> | |||
| <p><a>Set the configuration</a> specified by | |||
| <p>Let <var>connection</var> have a <dfn>[[Configuration]]</dfn> | |||
There was a problem hiding this comment.
Needs to be [[\Configuration]] (with backslash), otherwise this gets interpreted as a bibliography link
moves the algorithm to set a configuration to the operations section.
Also mentions the [[configuration] internal slot in the constructor.
fixes #1200
Preview | Diff