Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for negotiation-needed are underspecified when currentLocalDescription/currentRemoteDescription are not set #1375

Closed
docfaraday opened this issue Jun 12, 2017 · 4 comments

Comments

@docfaraday
Copy link
Contributor

The following language does not work if the PC has not performed an initial negotiation. (Transceivers are expected to be associated before offer/answer completes, so this language can apply in this situation)

"

  • If t's direction is "sendrecv" or "sendonly", and the associated m= section in connection's currentLocalDescription doesn't contain an "a=msid" line, return "true".

  • If connection's currentLocalDescription if of type "offer", and the direction of the associated m= section in neither the offer nor answer matches t's direction, return "true".

  • If connection's currentLocalDescription if of type "answer", and the direction of the associated m= section in the answer does not match t's direction intersected with the offered direction (as described in [JSEP] (section 5.3.1.)), return "true".

"

@jan-ivar
Copy link
Member

@adam-be Any progress here? Seems valid.

@aboba aboba assigned stefhak and unassigned adam-be Jan 4, 2018
@stefhak
Copy link
Contributor

stefhak commented Jul 5, 2018

I think this issue is invalid. Before these three bullets it's said:
"If transceiver isn't stopped and isn't yet associated with an m= section in description, return true.", and the text in #1375 (comment) would only come into play if the transceiver is associated with a m= section.

@stefhak
Copy link
Contributor

stefhak commented Jul 9, 2018

@docfaraday do you think we can close this issue?

@stefhak
Copy link
Contributor

stefhak commented Jul 13, 2018

Closing due to lack of submitter input. Feel free to reopen if you think this is wrong.

@stefhak stefhak closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants