Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values for RTCRtpEncodingParameters #1491

Closed
soareschen opened this issue Jul 17, 2017 · 0 comments
Closed

Default values for RTCRtpEncodingParameters #1491

soareschen opened this issue Jul 17, 2017 · 0 comments
Assignees

Comments

@soareschen
Copy link
Contributor

The current definition seems to imply that all fields are optional and have the value undefined if not set. However it seems that at least some of the fields should have default values, e.g. active and priority.

For example, the following examples have different active values:

// sender.encodings[0].active == true
pc.addTransceiver('audio');

// sender.encodings[0].active == true
pc.addTransceiver('audio', { sendEncodings: [] });

// sender.encodings[0].active == undefined
pc.addTransceiver('audio', { sendEncodings: [{}] });
@aboba aboba added the question label Jul 17, 2017
taylor-b added a commit to taylor-b/webrtc-pc that referenced this issue Aug 9, 2017
Fixes w3c#1491.

The rest of the encoding parameters (`ptime`, `maxBitrate`,
`maxFramerate`, etc.) are optional, but `active` and `priority` need
default values in case they aren't specified in the `sendEncodings`
passed into `addTransceiver`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants