Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getCapabilities should throw TypeError if invalid kind is provided #1495

Closed
soareschen opened this issue Jul 19, 2017 · 2 comments
Closed

getCapabilities should throw TypeError if invalid kind is provided #1495

soareschen opened this issue Jul 19, 2017 · 2 comments
Assignees
@aboba
Labels
PR exists

Comments

@soareschen
Copy link
Contributor

Currently the behavior for invalid kind is undefined.
@aboba aboba assigned soareschen and unassigned taylor-b Jul 27, 2017
@aboba
Copy link
Contributor

aboba commented Jul 27, 2017

@soareschen Can you submit a PR?

@aboba
Copy link
Contributor

aboba commented Aug 17, 2017

I believe that getCapabilities(kind) will return null if kind is unsupported, rather than throwing a TypeError. This seems preferable, because kind can be extended by other specifications. For example, we cannot say that kind needs to be "audio" or "video" because https://www.w3.org/TR/mediacapture-depth/ defines the "depth" kind, and therefore getCapabilities("depth") might return capabilities in some implementations.

aboba added a commit that referenced this issue Aug 17, 2017
@aboba
getCapabilities behavior with an unsupported value of kind
af88e79 
Fix for Issue #1495
@aboba aboba assigned aboba and unassigned soareschen Aug 17, 2017
This was referenced Aug 17, 2017
Merged
Closed
@aboba aboba closed this as completed Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aboba aboba

Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soareschen @aboba @taylor-b