Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if RTCDataChannelInit.negotiated is true, but id is absent? #1529

Closed
taylor-b opened this issue Aug 9, 2017 · 3 comments
Closed
Assignees

Comments

@taylor-b
Copy link
Contributor

taylor-b commented Aug 9, 2017

This is the inverse of #1413: an application negotiating the data channel out-of-band, but not providing an ID. This is guaranteed to not work, since one side would select an even ID and one side would select an odd ID, and they wouldn't match up. So unless I'm missing something, I think we should throw an error when this is attempted.

@lgrahl
Copy link
Contributor

lgrahl commented Aug 15, 2017

I think we should throw an error when this is attempted.

👍 for an explicit API.

Again, I believe we should eventually unify negotiated and id unless there's a use case for having them separate (as commented here earlier). Edit (as a note to that comment): We could use a completely new field called negotiatedId and have a transitional period where current behaviour is applied in case negotiated or id is present and new behaviour in case negotiatedId is present.

@stefhak
Copy link
Contributor

stefhak commented Aug 17, 2017

@adam-be to provide a PR.

@adam-be
Copy link
Member

adam-be commented Aug 24, 2017

Patched our current behavior, but I agree that the single attribute API mentioned above is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants