Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw if a DataChannel, negotiated by the script, lacks id #1558

Merged
merged 2 commits into from
Aug 30, 2017
Merged

Throw if a DataChannel, negotiated by the script, lacks id #1558

merged 2 commits into from
Aug 30, 2017

Conversation

adam-be
Copy link
Member

@adam-be adam-be commented Aug 24, 2017 •
edited by pr-preview bot
Loading

taylor-b
taylor-b approved these changes Aug 24, 2017
View reviewed changes
webrtc.html
<a>[[\DataChannelId]]</a> is <code>null</code>, <a>throw</a>
a <code>TypeError</code>.</p>
</li>
<li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Doesn't really make a difference, but for organizational purposes it would make sense to move this up one step, so it's right after [[DataChannelId]] being set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@aboba aboba merged commit a837a61 into master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboba aboba aboba left review comments

@taylor-b taylor-b taylor-b approved these changes

Assignees
No one assigned
Labels
Editors can integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam-be @aboba @taylor-b