Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats & isolated streams #1613

Closed
dontcallmedom opened this issue Sep 26, 2017 · 12 comments
Closed

Stats & isolated streams #1613

dontcallmedom opened this issue Sep 26, 2017 · 12 comments
Assignees

Comments

@dontcallmedom
Copy link
Member

While doing a first pass at a security review for WebRTC stats, I noticed the text on isolated media streams in WebRTC 1.0 leaves open the access to stats for them:

In particular, the statistics that RTCPeerConnection records are not reduced in capability. New statistics that might compromise isolation MUST be avoided, or explicitly suppressed for isolated streams.

It sounds like stats might leak a lot about isolated streams to the JavaScript layer, so @aboba suggested I raise an issue so that we look more closely into this.

@aboba
Copy link
Contributor

aboba commented Sep 28, 2017

@vr00m What do you think?

@vr000m
Copy link

vr000m commented Oct 13, 2017

Do we need a minimum set of stats that does not compromise the isolated stream and still helps with debugging issues? or we leave that to the implementors to pick?

@dontcallmedom
Copy link
Member Author

I don't see why we should not leave it to implementors - this needs to be interoperable as far as I can tell.

@alvestrand
Copy link
Contributor

@dontcallmedom one too many "not" in that sentence?

@dontcallmedom
Copy link
Member Author

yes, I meant "I don't see why we should leave it to implementors" :)

@alvestrand
Copy link
Contributor

So far, I know that volume leaks information. The fact that there is a call (and associated info such as IP addresses) doesn't seem to warrant different treatment for isolated vs non-isolated streams.
So what else in track stats should be treated differently, if anything?

@dontcallmedom
Copy link
Member Author

This needs to address also CSRC and SSRC and isolated streams

@alvestrand
Copy link
Contributor

Dan will take a look at his notes to try to reproduce consensus. @vr000m do you remember?

@stefhak
Copy link
Contributor

stefhak commented Nov 30, 2017

@burnburn
Copy link
Contributor

I confirmed in my notes that Harald was going to do a PR because there is not a blanket answer here across all types of stats.

@vr000m
Copy link

vr000m commented Dec 1, 2017

AFAICR, to do a PR to suggest not reporting stats that leak. IIRC: it was CSRC and volume.

@alvestrand
Copy link
Contributor

Created w3c/webrtc-stats#352 to forbid reporting CSRC and audioHandler.audioLevel.

alvestrand added a commit to w3c/webrtc-stats that referenced this issue Jun 27, 2018
* Added list of forbidden stats for isolated streams.

Fixes w3c/webrtc-pc#1613

If the list needs to be longer, we'll add more to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants