Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should rollback fire addtrack/removetrack events? #1706

Closed
jan-ivar opened this issue Dec 21, 2017 · 5 comments · Fixed by #2298
Closed

Should rollback fire addtrack/removetrack events? #1706

jan-ivar opened this issue Dec 21, 2017 · 5 comments · Fixed by #2298
Assignees

Comments

@jan-ivar
Copy link
Member

jan-ivar commented Dec 21, 2017

SRD(offer) can cause the following events to fire: track, mute, addtrack, and removetrack, as well as cause tracks to be added/removed from the remotely managed stream(s).

Should a rollback undo any/all of that? How do we undo the track event? E.g should we undo the mute event by firing the unmute event?

@docfaraday
Copy link
Contributor

I guess it depends on whether the intent is to allow sessions to continue functioning normally after a sRD(rollback), without requiring a subsequent negotiation to set the record straight. I think this is the intent, right?

@stefhak
Copy link
Contributor

stefhak commented Jan 2, 2018

@docfaraday I have the same understanding of the intent (#1706 (comment)) as you.

@aboba
Copy link
Contributor

aboba commented Apr 16, 2018

Consensus from the April VI is for Jan-Ivar to produce a PR along the lines described in the slides.

@stefhak
Copy link
Contributor

stefhak commented Jul 18, 2018

@jan-ivar do you think we can close this Issue now that #1867 has been merged?

@jan-ivar
Copy link
Member Author

No, #1867 fixed missing events from remote rejection (#1778), not rollback.

@alvestrand alvestrand added this to To do in WebRTC 1.0 to PR Aug 22, 2019
@alvestrand alvestrand moved this from To do to In progress in WebRTC 1.0 to PR Oct 17, 2019
WebRTC 1.0 to PR automation moved this from In progress to Done Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants