Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 14 never sends any media #1708

Closed
stefhak opened this issue Jan 2, 2018 · 4 comments · Fixed by #2271
Closed

Example 14 never sends any media #1708

stefhak opened this issue Jan 2, 2018 · 4 comments · Fixed by #2271
Assignees
@jan-ivar
Labels
Editorial PR exists
Projects
WebRTC 1.0 to PR

Comments

@stefhak
Copy link
Contributor

stefhak commented Jan 2, 2018

https://w3c.github.io/webrtc-pc/#peer-to-peer-example-with-media-before-signaling

There is no addTrack or replaceTrack.
@alvestrand
Copy link
Contributor

I believe this is by design - the example's focus is on receiving media, not sending it.

@stefhak
Copy link
Contributor Author

stefhak commented Jan 2, 2018

The comment in the code - // get a local stream, show it in a self-view and add it to be sent makes me think it's not by design. Anyway, we should probably sort out #1709 before going into these details.

@alvestrand
Copy link
Contributor

Suggested fix:

  • Change the title to "with incoming media before signaling"
  • Change the intro to add "This code shows the receiving side"
  • Remove the "selfView" code

I think that focuses the example better on what it's supposed to be about.

@stefhak stefhak mentioned this issue Jan 3, 2018
Closed
@aboba aboba mentioned this issue Jul 11, 2018
Closed
@aboba aboba assigned aboba and unassigned adam-be Jul 11, 2018
@aboba aboba removed their assignment Jul 16, 2018
@aboba aboba removed the PR exists label Jul 16, 2018
@alvestrand alvestrand added this to To do in WebRTC 1.0 to PR May 16, 2019
dontcallmedom added a commit that referenced this issue Aug 12, 2019
@dontcallmedom
Clarify example on example with media before signaling
9241779 
As per discussion in #1708:
* Change the title to 'with incoming media before signaling'
* Change the intro to add 'This code shows the receiving side'
* Remove the 'selfView' code

close #1708
@dontcallmedom dontcallmedom mentioned this issue Aug 12, 2019
Closed
dontcallmedom added a commit that referenced this issue Aug 14, 2019
@dontcallmedom
As per discussion in #1708:
7a8f770 
* Change the title to 'with incoming media before signaling'
* Change the intro to add 'This code shows the receiving side'
* Remove the 'selfView' code
close #1708
dontcallmedom added a commit that referenced this issue Aug 14, 2019
@dontcallmedom
As per discussion in #1708:
4c97e90 
* Change the title to 'with incoming media before signaling'
* Change the intro to add 'This code shows the receiving side'
* Remove the 'selfView' code
close #1708
@dontcallmedom
Copy link
Member

#1926 proposes removing the example, which would solve the issue

dontcallmedom added a commit that referenced this issue Aug 14, 2019
@dontcallmedom
Remove example on media before signaling
8048fbb 
as suggested in #1926
close #1926
close #1708
@dontcallmedom dontcallmedom mentioned this issue Aug 14, 2019
Merged
dontcallmedom added a commit that referenced this issue Aug 14, 2019
@dontcallmedom
Remove example on media before signaling
6164d5b 
as suggested in #1926
close #1709
close #1708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-ivar jan-ivar

Labels
Editorial PR exists
Projects
WebRTC 1.0 to PR
  
To do
Milestone
No milestone
6 participants
@dontcallmedom @alvestrand @aboba @stefhak @adam-be @jan-ivar