Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need <section> around dictionaries under RTCRtpSender #1749

Closed
alvestrand opened this issue Jan 30, 2018 · 1 comment
Closed

Need <section> around dictionaries under RTCRtpSender #1749

alvestrand opened this issue Jan 30, 2018 · 1 comment
Labels
Editorial PR exists

Comments

@alvestrand
Copy link
Contributor

As it stands, the spec reads oddly after the RTCRtpSender section; the definition of the dictionaries comes one after the other, with no bracketing

binding each dictionary IDL to its list of attributes.

This concerns RTCRtpParameters, RTCRtpEncodingParameters, RTCDegradationPreference, RTCRtcpParameters, RTCRtpHeaderExtensionParameters, RTCRtpCodecParameters, RTCRtpCapabilities, RTCRtpCodecCapability, RTCRtpHEaderExtensionCapability. These actually live outside the RTCRtpSender section altogether, kind of in limbo.

They would be better off as subsections under RTCRtpSender.
@alvestrand
Copy link
Contributor Author

kudos to @Orphis for noting the issue.

@aboba aboba mentioned this issue Jan 30, 2018
Merged
dontcallmedom pushed a commit that referenced this issue Feb 5, 2018
@aboba @dontcallmedom
Need <section> around dictionaries under RTCRtpSender
e76a4e7 
Fix for Issue #1749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Editorial PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alvestrand @aboba