Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out unmute and BYE #1752

Closed
stefhak opened this issue Jan 31, 2018 · 5 comments
Closed

Sort out unmute and BYE #1752

stefhak opened this issue Jan 31, 2018 · 5 comments
Assignees

Comments

@stefhak
Copy link
Contributor

stefhak commented Jan 31, 2018

Brought up in #1748 (comment)

It is said that "an out of order packet should not unmute if BYE initiated mute".
@fluffy : should an in order packet received after the BYE unmute?

To me it even seems strange that a BYE for one SSRC should mute in the case that we still receive packets for other SSRCs used for this track. What's the rationale?

@alvestrand
Copy link
Contributor

When we discussed this last, the thought was that the BYE for another SSRC could have gotten lost (BYEs are not guaranteed to be delivered) - if we didn't react to just one BYE, we'd not mute the track until the SSRC times out.
I think an in-order packet received after a BYE is a spec violation on the sender's side, but I could be wrong about that.

@aboba aboba assigned stefhak and unassigned aboba Apr 19, 2018
@aboba
Copy link
Contributor

aboba commented Apr 19, 2018

After an source sends a BYE it should not be sending more packets. However, if it was a conflict that lead to the sending of the BYE then packets could still be sent by the sender who is the rightful owner of the SSRC.

@stefhak
Copy link
Contributor Author

stefhak commented Jul 5, 2018

@fluffy is what was added in #1748 enough? Can we close this issue?

@fluffy
Copy link
Contributor

fluffy commented Jul 26, 2018

I think this is enough of an edge case we can ignore it and just close the issue

@stefhak
Copy link
Contributor Author

stefhak commented Jul 27, 2018

Thanks @fluffy - closing.

@stefhak stefhak closed this as completed Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants