-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort out unmute and BYE #1752
Comments
When we discussed this last, the thought was that the BYE for another SSRC could have gotten lost (BYEs are not guaranteed to be delivered) - if we didn't react to just one BYE, we'd not mute the track until the SSRC times out. |
After an source sends a BYE it should not be sending more packets. However, if it was a conflict that lead to the sending of the BYE then packets could still be sent by the sender who is the rightful owner of the SSRC. |
I think this is enough of an edge case we can ignore it and just close the issue |
Thanks @fluffy - closing. |
Brought up in #1748 (comment)
It is said that "an out of order packet should not unmute if BYE initiated mute".
@fluffy : should an in order packet received after the BYE unmute?
To me it even seems strange that a BYE for one SSRC should mute in the case that we still receive packets for other SSRCs used for this track. What's the rationale?
The text was updated successfully, but these errors were encountered: