Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc.close() almost stops transceivers fully. #1894

Closed
jan-ivar opened this issue Jun 15, 2018 · 0 comments
Closed

pc.close() almost stops transceivers fully. #1894

jan-ivar opened this issue Jun 15, 2018 · 0 comments
Assignees

Comments

@jan-ivar
Copy link
Member

pc.close() rolls its own version of stop transceiver that is almost—but not quite—identical to tc.stop().

The difference looks accidental: It forgets to set [[Receptive]]=false and [[CurrentDirection]]=null.

These somewhat recent additions look like they got out of sync.

We probably want to rewrite this to reference a common algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant