Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setLocal and setRemote wrong #1950

Closed
boldt opened this issue Aug 1, 2018 · 3 comments · Fixed by #1951
Closed

setLocal and setRemote wrong #1950

boldt opened this issue Aug 1, 2018 · 3 comments · Fixed by #1951
Assignees

Comments

@boldt
Copy link

boldt commented Aug 1, 2018

In subsection 4.3.1 RTCSignalingState Enum you write:

Caller transition:

   new RTCPeerConnection(): stable
   setLocal(offer): have-local-offer
   setRemote(pranswer): have-remote-pranswer
   setRemote(answer): stable

Callee transition:

   new RTCPeerConnection(): stable
   setRemote(offer): have-remote-offer
   setLocal(pranswer): have-local-pranswer
   setLocal(answer): stable

setLocal must be setLocalDescription and setRemote must be setRemoteDescription.
The same goes for the Figure in the same subsection.

@jan-ivar
Copy link
Member

jan-ivar commented Aug 1, 2018

Correct. Maybe the shorter names were used for brevity in the diagram? This is pseudo code after all.

@fippo
Copy link
Contributor

fippo commented Aug 1, 2018

to make things worse the diagram seems to be a mix of pixel text and actual svg text. And neither inkscape or gimp import it correctly which makes updating it very hard :-/

fippo added a commit to fippo/webrtc-pc that referenced this issue Aug 1, 2018
fippo added a commit to fippo/webrtc-pc that referenced this issue Aug 1, 2018
@jan-ivar jan-ivar self-assigned this Aug 1, 2018
@boldt
Copy link
Author

boldt commented Aug 1, 2018

@fippo If you're interested, I can create some "new" figures with Tikz. Just let me know.

@aboba aboba closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants