Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setRemoteDescription() adding and removing tracks to streams should be synchronous #1993

Closed
henbos opened this issue Sep 26, 2018 · 0 comments

Comments

@henbos
Copy link
Contributor

henbos commented Sep 26, 2018

trackEventInits, muteTracks, addList and removeList were added to make events firing well defined and immediate, so that the application does not get ahold of objects before they are properly updated according to the algorithm.

With regards to addList and removeList, we reference mediacapture-streams for adding and removing tracks to the stream.

This does fire the event synchronously after adding/removing the stream (good), but as is written the algorithm is supposed to be executed by queuing a "task that runs the following steps". The same goes with muting.

This means that "ontrack" will fire first, exposing tracks and streams to the application, and then after a delay the tracks will be unmuted, added to the streams, etc.

Do we need to revisit these things to not say "queue a task that"? (Leaving any necessary queuing to the caller of these algorithms)

@aboba aboba closed this as completed Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants