Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCErrorEvent constructor's RTCErrorEventInit parameter should be optional #2070

Closed
henbos opened this issue Jan 21, 2019 · 2 comments
Closed

RTCErrorEvent constructor's RTCErrorEventInit parameter should be optional #2070

henbos opened this issue Jan 21, 2019 · 2 comments
Assignees
@henbos
Labels
Ready for PR

Comments

@henbos
Copy link
Contributor

henbos commented Jan 21, 2019

Because RTCErrorEventInit contains not required attributes, and as such can be constructed from {}, the recommendation (@foolip) is that when this type is used as an argument, that argument is optional. That is:

Constructor(DOMString type, optional RTCErrorEventInit eventInitDict)

Here: https://w3c.github.io/webrtc-pc/#dom-rtcerrorevent
@henbos henbos self-assigned this Jan 21, 2019
@foolip
Copy link
Member

foolip commented Jan 21, 2019

I can't find the wording in the Web IDL spec now, but whatwg/webidl#130 has more background.

@henbos
Copy link
Contributor Author

henbos commented Feb 14, 2019

This is obsolete, final stuff in #2070.

@henbos henbos closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henbos henbos

Labels
Ready for PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foolip @henbos