Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCPeerConnection.prototype.setRemoteDescription.length should be 1 #2528

Closed
jan-ivar opened this issue May 10, 2020 · 0 comments · Fixed by #2529
Closed

RTCPeerConnection.prototype.setRemoteDescription.length should be 1 #2528

jan-ivar opened this issue May 10, 2020 · 0 comments · Fixed by #2529
Assignees
@jan-ivar
Labels
PR exists

Comments

@jan-ivar
Copy link
Member

jan-ivar commented May 10, 2020 •
edited

It regressed to 0 last year when we made RTCSessionDescriptionInit's type a non-required member to support SLD() without arguments (SLD & sRD take the same dictionary).

We can fix this, at the cost of some spec duplication. (a new RTCLocalSessionDescriptionInit).
@jan-ivar jan-ivar self-assigned this May 10, 2020
@fippo fippo mentioned this issue May 11, 2020
Open
@jan-ivar jan-ivar mentioned this issue May 12, 2020
Merged
@jan-ivar jan-ivar changed the title RTCPeerConnection().prototype.setRemoteDescription.length should be 1 RTCPeerConnection.prototype.setRemoteDescription.length should be 1 May 12, 2020
@tidoust tidoust mentioned this issue Feb 20, 2024
Closed
@jarrodcolburn jarrodcolburn mentioned this issue Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-ivar jan-ivar

Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split off RTCLocalSessionDescriptionInit to handle optional type. jan-ivar/webrtc-pc
1 participant
@jan-ivar