Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ongatheringstatechange references wrong ICE gathering state #2825

Open
jan-ivar opened this issue Feb 13, 2023 · 0 comments
Open

ongatheringstatechange references wrong ICE gathering state #2825

jan-ivar opened this issue Feb 13, 2023 · 0 comments
Assignees

Comments

@jan-ivar
Copy link
Member

RTCIceTransport's ongatheringstatechange accidentally references the RTCPeerConnection's ICE gathering state, calling it "RTCIceTransport's".

A while back, we converted most state to internal slots, except these four: signaling state, connection state, ice gathering state, and ICE connection state.

It'd be nice to finish this cleanup, to avoid further accidents of this kind.

@jan-ivar jan-ivar self-assigned this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant