New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framerate knob for simulcast #412

Closed
stefhak opened this Issue Dec 3, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@stefhak
Copy link
Contributor

stefhak commented Dec 3, 2015

The discussion at TPAC concluded that we need a knob to control framerate per stream when simulcast is used.

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Dec 9, 2015

How about this?

partial dictionary RTCRtpEncodingParameters {
unsigned long maxFramerate;
};

maxFramerate of type unsigned long
The maximum framerate to use for this encoding.

A remaining question: how is the receiver's maximum framerate determined? This could be codec-specific, because a device might support hardware decoding for one codec, but not another.

Since not all codecs include a max-fr SDP parameter (e.g. VP8 does, but H.264 does not), this value cannot be determined from SDP for all codecs.

Do this imply that we need to add maxFramerate as a generic codec capability in RTCRtpCodecCapability? Today, all we have is mimeType.

aboba added a commit that referenced this issue Dec 10, 2015

Issue 412: Framerate knob for simulcast
Added maxFramerate to RTCRtpEncodingParameters, addressing Issue 412: 
#412

@aboba aboba added the PR exists label Dec 10, 2015

@elagerway

This comment has been minimized.

Copy link
Contributor

elagerway commented Jan 12, 2016

This issue has been flagged for discussion at the interim on Thursday, Slides placeholder: https://docs.google.com/presentation/d/1qfaxn8GMplm__s_ejMq6C3atA_pBnGXsjmAkKNIh3Ds/edit#slide=id.gf7328a83a_1_27

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Jan 19, 2016

At the interim, I believe that consensus was to leave maxFramerate in the spec, and not put in another framerate knob. If so, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment