Server cannot be reached - Issues with IPv6 #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Issue #542
Clarification on re-firing
|
@taylor-b Can you review? |
| @@ -2641,9 +2641,10 @@ | |||
| <dd> | |||
| <p>The <code>errorCode</code> attribute is the numeric STUN | |||
| error code returned by the STUN or TURN server [[STUN-PARAMETERS]].</p> | |||
| <p>If the server could not be reached, <code>errorCode</code> will | |||
| <p>If the server could not be reached from all host candidates, <code>errorCode</code> will | |||
There was a problem hiding this comment.
I think this would be more clear if worded as "If no host candidate could reach the server, ..."
Sentence structure cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #542