Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RTCPeerConnectionIceErrorEvent constructor should have an optional init dict #857

Closed
foolip opened this issue Oct 6, 2016 · 2 comments
Assignees

Comments

@foolip
Copy link
Member

foolip commented Oct 6, 2016

https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#rtcpeerconnectioniceerrorevent

Or, alternatively, at least one of the init dict members should be required.

@adam-be
Copy link
Member

adam-be commented Oct 13, 2016

My guess is that we want to require at least errorCode to have a meaningful event.

@foolip
Copy link
Member Author

foolip commented Oct 13, 2016

Event constructors are mostly pointless and not used, so unless there's some invariant to be maintained that would simplify implementations, I would make it as simple as possible, giving everything a default value. That way you don't even need any prose to say what the defaults are, and implementations can just copy-paste the IDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants