Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sender.setParameters(): Changing simulcast parameters? #945

Closed
aboba opened this issue Nov 14, 2016 · 2 comments
Closed

sender.setParameters(): Changing simulcast parameters? #945

aboba opened this issue Nov 14, 2016 · 2 comments
Assignees

Comments

@aboba
Copy link
Contributor

aboba commented Nov 14, 2016

Section 5.2 says:

"setParameters does not cause SDP renegotiation and can only be used to change what the media stack is sending or receiving within the envelope negotiated by Offer/Answer. The attributes in the RTCRtpParameters dictionary are designed to not enable this, so attributes like ssrc that cannot be changed are read only. "

[BA] This is reasonable as far as it goes. However, in addition to changing read/write parameters relevant to simulcast (e.g. maxFramerate, scaleResolutionDownBy, etc.) setParameters() could be used to change things like the number of encodings to be sent.

Are changes like adding encodings "outside the envelope negotiated by Offer/Answer"? What about removing encodings?

@aboba
Copy link
Contributor Author

aboba commented Dec 8, 2016

@pthatcherg Does the following make sense?

setParameters cannot set the negotiation-needed flag and therefore must operate within the envelope negotiated by Offer/Answer. Once setLocalDescription has been called, the envelope is set and the number of simulcast encodings cannot be changed.

If a transceiver is constructed with sendEncodings specifying N simulcast encodings, and setLocalDescription has been called, setParameters cannot be used to increase or decrease the number of simulcast encodings. However, if setLocalDescription has not yet been called, setParameters can be used to change the number of encodings and the parameters set will be reflected in the SDP produced by createOffer/createAnswer.

setParameters can be used to activate or inactivate a simulcast encoding at any time by setting encodings[].active. If the desire is to stop sending one or more simulcast encodings, this can be accomplished by setting encodings[].active to "false". If the desire is to re-enable a simulcast encoding that is inactive, this can be accomplished by setting encodings[].active back to "true".

@aboba aboba self-assigned this Dec 8, 2016
@alvestrand
Copy link
Contributor

Solved by #970

youennf pushed a commit to youennf/webrtc-pc that referenced this issue Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants