Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should sender.get/setParameters work on a stopped sender? #965

Closed
jan-ivar opened this issue Dec 7, 2016 · 2 comments
Closed

How should sender.get/setParameters work on a stopped sender? #965

jan-ivar opened this issue Dec 7, 2016 · 2 comments
Assignees

Comments

@jan-ivar
Copy link
Member

jan-ivar commented Dec 7, 2016

Should it throw InvalidStateError like sender.replaceTrack or be a no-op/return last set value?

@aboba
Copy link
Contributor

aboba commented Dec 8, 2016

@jan-ivar How about this?

getParameters returns the last value set (even if pc is closed??)

setParameters rejects the promise with InvalidStateError if transceiver.stopped is true.

Other cases:
If sender.track is null or the value of transceiver.currentDirection is recvonly, the sender will not send, but I'd suggest this not cause the promise to be rejected.

@alvestrand
Copy link
Contributor

Since getParameters doesn't need to be special-cased, and pc.stop() stops all transceivers, the merge of #966 seems to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants