Specify how media is centered, cropped, and scaled. Fixes #305 #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. AFAICR this is what we agreed in Lisbon. |
|
LGTM. |
jan-ivar
approved these changes
Feb 16, 2017
webrtc.html
Outdated
| the desired size, then finally cropped to the destination | ||
| size. The video remains centered while scaling and cropping. For | ||
| example, if the source video was 1280 by 720, and the max size | ||
| that could be send was 640 by 480, the video would be scaled |
webrtc.html
Outdated
| @@ -4971,6 +4971,23 @@ <h2 id="sec.cert-mgmt">Certificate Management</h2> | |||
| encoded and transmitted to a remote peer. When <code>setParameters</code> | |||
| is called on an <code><a>RTCRtpSender</a></code> object, the encoding is | |||
| changed appropriately.</p> | |||
|
|
|||
| <p>When sending media, the sender may need to rescale or | |||
| resample the media to meet various constraints including the | |||
There was a problem hiding this comment.
Maybe s/constraints/requirements/ to avoid confusion with mediacapture constraints?
|
@fluffy can you take a look at the comments? |
|
Agree with Jan-ivar, made all his suggested changes. Thanks |
alvestrand
reviewed
Mar 1, 2017
webrtc.html
Outdated
| down by 1.5 and 160 columns of pixels on both the right and left | ||
| sides of the source video would be cropped off. This algorithm | ||
| is designed to minimize occurrence of images with with letter | ||
| box or or pillow boxing. The media MUST never be upscaled to |
There was a problem hiding this comment.
MUST NOT is better than "MUST never".
alvestrand
reviewed
Mar 1, 2017
webrtc.html
Outdated
| sides of the source video would be cropped off. This algorithm | ||
| is designed to minimize occurrence of images with with letter | ||
| box or or pillow boxing. The media MUST never be upscaled to | ||
| create fake samples data that was did not actually occur in the |
There was a problem hiding this comment.
Grammar, better: "to create fake data that did not occur in the input source."
|
Made the changes suggested by HTA. Thanks |
|
Based on discussion at the virtual interim, I believe this PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.