Call RTCDtlsFingerprint a dictionary, not an object #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTCDtlsFingerprint is a dictionary. Web IDL says that "IDL dictionary type values are represented by ECMAScript Object values", but they are not the same: https://heycam.github.io/webidl/#es-dictionary
foolip
commented
Apr 21, 2017
| @@ -7189,9 +7189,9 @@ <h2 id="sec.cert-mgmt">Certificate Management</h2> | |||
| </table> | |||
| </div> | |||
| <section id="rtcdtlsfingerprint*"> | |||
There was a problem hiding this comment.
Any idea why this ID ends with a *? Compare with https://w3c.github.io/webrtc-pc/#rtciceserver-dictionary?
(Matters somewhat because we link to the sections from Blink's IDL files, and if this is a typo it'll presumably change.)
There was a problem hiding this comment.
It's an artifact, due to the section being copied from the ORTC API spec.
aboba
approved these changes
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTCDtlsFingerprint is a dictionary. Web IDL says that "IDL dictionary type
values are represented by ECMAScript Object values", but they are not the same:
https://heycam.github.io/webidl/#es-dictionary