Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error if data channel's buffer is filled, rather than closing. #1209

Merged
merged 4 commits into from
Jun 15, 2017
Merged

Throw error if data channel's buffer is filled, rather than closing. #1209

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
235529a
Throw error if data channel's buffer is filled, rather than closing.
taylor-b May 12, 2017
cf37ad1
Trying to make RTCDataChannel.send behavior more clear.
taylor-b Jun 14, 2017
d56f593
s/no more/not enough
taylor-b Jun 15, 2017
81de077
Change InvalidAccessError to TypeError.
taylor-b Jun 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8894,8 +8894,8 @@ <h2>Dictionary <dfn>RTCDataChannelInit</dfn> Members</h2>
</li>
<li>
<p>If <var>channel</var>'s <a data-for=
"RTCDataChannel"><code>readyState</code></a> attribute is
<code>connecting</code>, <a>throw</a> an
"RTCDataChannel"><code>readyState</code></a> attribute is not
<code>open</code>, <a>throw</a> an
<code>InvalidStateError</code>.</p>
</li>
<li>
Expand Down Expand Up @@ -8941,11 +8941,20 @@ <h2>Dictionary <dfn>RTCDataChannelInit</dfn> Members</h2>
started, then abort these steps.</p>
</li>
<li>
<p>Attempt to send <var>data</var> on <var>channel</var>'s
<a>underlying data transport</a>; if the data cannot be sent, e.g.
because it would need to be buffered but the buffer is full, the user
agent MUST abruptly <a>close</a> <var>channel</var>'s <a>underlying
data transport</a> <a>with an error</a>.</p>
<p>If the size of <var>data</var> exceeds the value of <code><a
data-link-for="RTCSctpTransport">maxMessageSize</a></code> on
<var>channel</var>'s associated <code>RTCSctpTransport</code>,
<a>throw</a> an <code>InvalidAccessError</code>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should go with an operation error here as well since InvalidAccessError is deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. What's the new "invalid parameter" error, then?

</li>
<li>
<p>Queue <var>data</var> for transmission on <var>channel</var>'s
<a>underlying data transport</a>. If queuing <var>data</var> is not
possible because no more buffer space is available, <a>throw</a> an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/no/not enough/ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<code>OperationError</code>.</p>
<div class="note">The actual transmission of data occurs in
parallel. If sending data leads to an SCTP-level error, the
application will be notified asynchronously through <code><a
data-link-for="RTCDataChannel">onerror</a></code>.</div>
</li>
</ol>
<div>
Expand Down