Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTP/RTCP mux -> RTCP mux #1247

Merged
merged 1 commit into from Jun 1, 2017
Merged

RTP/RTCP mux -> RTCP mux #1247

merged 1 commit into from Jun 1, 2017

Conversation

fippo
Copy link
Contributor

@fippo fippo commented May 25, 2017

replace single use of RTP/RTCP mux with just RTCP mux for consitency with
other uses

We also don't define "RTCP mux" anywhere and don't have a reference to RFC 5763. Should we?

@taylor-b
Copy link
Contributor

In the description of RTCIceComponent, there's also the phrase "RTP/RTCP-multiplexing". Can you replace that too?

replace single use of 'RTP/RTCP mux' with just 'RTCP mux' for consitency with
other uses. Also replaces RTP/RTCP-multiplexing with 'RTCP multiplexing'.
@fippo
Copy link
Contributor Author

fippo commented May 25, 2017

ah... I was looking for that but searching for "RTCP mux" didn't catch it. Updated + squashed

@taylor-b
Copy link
Contributor

Regarding the reference, RFC 5763 actually never uses the phrase "RTCP mux", but JSEP frequently does. So I'm not sure what to do about that.

But this change in itself LGTM.

@taylor-b taylor-b merged commit 6370d9c into w3c:master Jun 1, 2017
rwaldron added a commit to rwaldron/webrtc-pc that referenced this pull request Jun 6, 2017
* 'gh-pages' of github.com:w3c/webrtc-pc: (44 commits)
  Added dated version v20170605
  editorial: Update change log
  RTP/RTCP mux -> RTCP mux (w3c#1247)
  Capitalize "ICE" in "ICE options"
  Clarify "trusted" origins as whitelisted
  Mark Bernard as former editor
  New ReSpec release v12.2.2
  remove note about identity is at risk
  Add "Read-only parameter" to codec parameter descriptions.
  RTCIceConnectionEventInit: url is nullable
  Set a specific respec release
  Responding to Bernard's comments.
  use data-site for RTCStatsType
  Removing WebIDL defaults for various RTP parameters.
  Units for maxFramerate
  +feedback taylor
  Change `component` to an `RTCIceComponent` enum
  Update webrtc.html
  Describe how RTCRtpParameters dictionary is constructed in more detail.
  Throw an error if a read-only parameter is passed into addTransceiver.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants