Highlighting errorCode 701 #1458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Issue #1281
taylor-b
reviewed
Jul 12, 2017
| @@ -4409,6 +4409,13 @@ | |||
| <p>The <code>icecandidateerror</code> event of the RTCPeerConnection | |||
| uses the <code><a>RTCPeerConnectionIceErrorEvent</a></code> | |||
| interface.</p> | |||
| <p>An <code><a>RTCPeerConnectionIceErrorEvent</a></code> event MUST | |||
There was a problem hiding this comment.
Two "MUST"s in a row here.
| @@ -4488,11 +4495,6 @@ | |||
| <p>The <code>errorCode</code> attribute is the numeric STUN | |||
| error code returned by the STUN or TURN server | |||
| [[STUN-PARAMETERS]].</p> | |||
| <p>If no host candidate can reach the server, | |||
There was a problem hiding this comment.
I don't think this text should be removed. It's normal to expect an attribute's description to describe all its possible values, without having to look elsewhere (in this case, "elsewhere" is the description of the containing dictionary).
|
Closing the issue as well as this PR since moving the text seems to create its own set of problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for response from EKR (do not merge).
Fix for Issue #1281
Preview | Diff